Skip to content

悬停效果改为在 JFXRippler 中实现#5757

Open
CiiLu wants to merge 6 commits intoHMCL-dev:mainfrom
CiiLu:bg
Open

悬停效果改为在 JFXRippler 中实现#5757
CiiLu wants to merge 6 commits intoHMCL-dev:mainfrom
CiiLu:bg

Conversation

@CiiLu
Copy link
Copy Markdown
Contributor

@CiiLu CiiLu commented Mar 8, 2026

放在 JFXRippler 中实现 JFXButton 等 JFoenix 控件也能有悬停效果

@Glavo
Copy link
Copy Markdown
Member

Glavo commented Mar 8, 2026

感觉改之后很多地方没有足够的空间显示阴影,看着很奇怪。

@Glavo
Copy link
Copy Markdown
Member

Glavo commented Apr 6, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the hover animation logic by moving it from RipplerContainer to JFXRippler, introducing a hoverOverlay rectangle and implementing mouse event handlers for background interpolation. The review feedback recommends using Animation or Timeline instead of Transition to prevent visual jumps during rapid mouse movements and suggests simplifying the interpolateBackground method for better efficiency.

Comment thread HMCL/src/main/java/com/jfoenix/controls/JFXRippler.java Outdated
Comment thread HMCL/src/main/java/com/jfoenix/controls/JFXRippler.java
Comment thread HMCL/src/main/java/com/jfoenix/controls/JFXRippler.java
@Glavo
Copy link
Copy Markdown
Member

Glavo commented Apr 17, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3d2410e06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCL/src/main/java/com/jfoenix/controls/JFXRippler.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants